<html>
<head><meta charset="utf-8"><title>Vec&lt;ProgramClause&lt;I&gt;&gt; chalk#369 · wg-traits · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/index.html">wg-traits</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Vec.3CProgramClause.3CI.3E.3E.20chalk.23369.html">Vec&lt;ProgramClause&lt;I&gt;&gt; chalk#369</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="192566692"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Vec%3CProgramClause%3CI%3E%3E%20chalk%23369/near/192566692" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> tirr-c <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Vec.3CProgramClause.3CI.3E.3E.20chalk.23369.html#192566692">(Apr 01 2020 at 17:50)</a>:</h4>
<p>I was grepping <code>Vec</code> in <code>chalk-ir</code> and found some <code>Vec&lt;ProgramClause&lt;I&gt;&gt;</code>, I want to give it a try</p>



<a name="192566825"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Vec%3CProgramClause%3CI%3E%3E%20chalk%23369/near/192566825" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> tirr-c <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Vec.3CProgramClause.3CI.3E.3E.20chalk.23369.html#192566825">(Apr 01 2020 at 17:51)</a>:</h4>
<p>a question though: does <code>ProgramClause&lt;I&gt;</code> need to be interned too?</p>



<a name="192579621"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Vec%3CProgramClause%3CI%3E%3E%20chalk%23369/near/192579621" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Vec.3CProgramClause.3CI.3E.3E.20chalk.23369.html#192579621">(Apr 01 2020 at 19:20)</a>:</h4>
<p><span class="user-mention" data-user-id="225196">@tirr-c</span> Hmm, I don't know that it has to be, but it also doesn't seem bad to do so</p>



<a name="192579632"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Vec%3CProgramClause%3CI%3E%3E%20chalk%23369/near/192579632" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Vec.3CProgramClause.3CI.3E.3E.20chalk.23369.html#192579632">(Apr 01 2020 at 19:21)</a>:</h4>
<p>It would be more consistent</p>



<a name="192579659"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Vec%3CProgramClause%3CI%3E%3E%20chalk%23369/near/192579659" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Vec.3CProgramClause.3CI.3E.3E.20chalk.23369.html#192579659">(Apr 01 2020 at 19:21)</a>:</h4>
<p>also, great!</p>



<a name="192613908"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Vec%3CProgramClause%3CI%3E%3E%20chalk%23369/near/192613908" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> tirr-c <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Vec.3CProgramClause.3CI.3E.3E.20chalk.23369.html#192613908">(Apr 02 2020 at 02:13)</a>:</h4>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span> alright! I'll start by interning <code>ProgramClause&lt;I&gt;</code>, will open a PR when it's done</p>



<a name="192840740"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Vec%3CProgramClause%3CI%3E%3E%20chalk%23369/near/192840740" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> tirr-c <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Vec.3CProgramClause.3CI.3E.3E.20chalk.23369.html#192840740">(Apr 03 2020 at 17:49)</a>:</h4>
<p>I've done interning <code>ProgramClause</code>, now looking at <code>Vec&lt;ProgramClause&gt;</code></p>



<a name="192840939"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Vec%3CProgramClause%3CI%3E%3E%20chalk%23369/near/192840939" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> tirr-c <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Vec.3CProgramClause.3CI.3E.3E.20chalk.23369.html#192840939">(Apr 03 2020 at 17:51)</a>:</h4>
<p><code>Environment</code> and <code>GoalData</code> have <code>Vec&lt;ProgramClause&gt;</code>, and I can see the one in <code>GoalData</code> needs to be interned</p>



<a name="192841049"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Vec%3CProgramClause%3CI%3E%3E%20chalk%23369/near/192841049" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> tirr-c <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Vec.3CProgramClause.3CI.3E.3E.20chalk.23369.html#192841049">(Apr 03 2020 at 17:51)</a>:</h4>
<p>but I'm not quite sure about the other one; it seems it's being mutated quite often</p>



<a name="192841219"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Vec%3CProgramClause%3CI%3E%3E%20chalk%23369/near/192841219" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> tirr-c <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Vec.3CProgramClause.3CI.3E.3E.20chalk.23369.html#192841219">(Apr 03 2020 at 17:53)</a>:</h4>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span> how do you think?</p>



<a name="192841646"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Vec%3CProgramClause%3CI%3E%3E%20chalk%23369/near/192841646" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> tirr-c <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Vec.3CProgramClause.3CI.3E.3E.20chalk.23369.html#192841646">(Apr 03 2020 at 17:56)</a>:</h4>
<p>ah it's not a mutation actually, it creates a new <code>Environment</code> every time</p>



<a name="192841760"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Vec%3CProgramClause%3CI%3E%3E%20chalk%23369/near/192841760" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> tirr-c <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Vec.3CProgramClause.3CI.3E.3E.20chalk.23369.html#192841760">(Apr 03 2020 at 17:57)</a>:</h4>
<p>so is it okay to intern both of them?</p>



<a name="192842503"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Vec%3CProgramClause%3CI%3E%3E%20chalk%23369/near/192842503" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Vec.3CProgramClause.3CI.3E.3E.20chalk.23369.html#192842503">(Apr 03 2020 at 18:02)</a>:</h4>
<p>probably :)</p>



<a name="192847051"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Vec%3CProgramClause%3CI%3E%3E%20chalk%23369/near/192847051" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Vec.3CProgramClause.3CI.3E.3E.20chalk.23369.html#192847051">(Apr 03 2020 at 18:37)</a>:</h4>
<p>Yeah, I'd say intern them both.</p>



<a name="192851494"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Vec%3CProgramClause%3CI%3E%3E%20chalk%23369/near/192851494" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> tirr-c <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Vec.3CProgramClause.3CI.3E.3E.20chalk.23369.html#192851494">(Apr 03 2020 at 19:13)</a>:</h4>
<p>opened a PR: <a href="https://github.com/rust-lang/chalk/pull/370" title="https://github.com/rust-lang/chalk/pull/370">https://github.com/rust-lang/chalk/pull/370</a></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>